feat: Added scripts to serve plugins locally for dev #140
Conversation
|
Slightly related - would be reasonable for these use cases to disable js plugins on the server side: deephaven/deephaven-core#4695 |
vite.config.js
Outdated
| export default { | ||
| // This config doesn't build anything, it just serves the files from the | ||
| // plugins directory | ||
| publicDir: 'plugins', |
There was a problem hiding this comment.
I'd like if we used port 4100 instead of the default port, and have the option to set it via environment variable/.env like in web-client-ui. Then we have:
3000: Enterprise
4000: web-client-ui
4010: Embedded grid
4020: Embedded chart
4100: JS Plugins
README.md
Outdated
| ```typescript | ||
| proxy['/js-plugins'] = { | ||
| target: 'http://localhost:5173', | ||
| changeOrigin: true, | ||
| rewrite: path => path.replace(/^\/js-plugins/, ''), | ||
| }; | ||
| ``` |
There was a problem hiding this comment.
We should have a follow up PR to have a flag for this, something like JS_PLUGINS_PORT or something that only kicks the proxy in if the value is set.
There was a problem hiding this comment.
I have another option for this that I've been playing with in my other PR.
Can also see the value of having an env flag as well.
There was a problem hiding this comment.
Yea a vite.config.local.ts could be useful for some things as well... annoying to add that extra flag for it, but I guess either way we're adding an extra flag somewhere
|
Also rebase off the latest so tests run correctly |
bmingles
force-pushed
the
1504-plugin-dev-server
branch
from
6d31b7a to
7338ae4
Compare
| npm run serve | ||
| ``` | ||
|
|
||
| This will serve the `plugins` directory at `http://localhost:5173` |
There was a problem hiding this comment.
Should the port in the readme match the default in the config?
const DEFAULT_PORT = 4100;
There was a problem hiding this comment.
Yes, I'll fix in another PR
npm run servescript to serve plugins locally. This can be used with Vite proxy for DHC or DHE locally